Started by an SCM change3420bf608a425587c65384f6532f3df94c1c84b84d60bf608a425587c65384f6532f3df94c1c84b84d6refs/remotes/origin/master0bf608a425587c65384f6532f3df94c1c84b84d60bf608a425587c65384f6532f3df94c1c84b84d6refs/remotes/origin/master0bf608a425587c65384f6532f3df94c1c84b84d60bf608a425587c65384f6532f3df94c1c84b84d6refs/remotes/origin/masterhttps://github.com/mcMMO-Dev/mcMMO.gitfalse#342241420135282mcMMO #342342falsefalse342215FAILURE1783740849710https://popicraft.net/jenkins/job/mcMMO/342/Buildersrc/main/java/com/gmail/nossr50/datatypes/skills/alchemy/AlchemyPotion.javasrc/main/java/com/gmail/nossr50/skills/alchemy/AlchemyManager.javasrc/test/java/com/gmail/nossr50/skills/alchemy/AlchemyTest.javasrc/test/java/com/gmail/nossr50/skills/alchemy/AlchemyPotionBrewerTest.javasrc/test/java/com/gmail/nossr50/datatypes/skills/alchemy/PotionStageTest.javasrc/test/java/com/gmail/nossr50/skills/alchemy/AlchemyManagerTest.javasrc/main/java/com/gmail/nossr50/skills/alchemy/AlchemyPotionBrewer.javasrc/test/java/com/gmail/nossr50/listeners/InventoryListenerBrewTest.javae53f74c2751dbcb5d0ecd5bf958088e35e18649d1783732629000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd alchemy unit test coverage and tidy alchemy internals Covers the Catalysis brew speed curve, Concoctions tier plumbing, potion stage math, brew and ingredient validation, finishBrewing, the disable-time brew flush, and the vanilla-brew race handler. Cleanup while in the area: clearer calculateBrewSpeed, removal of a duplicated base-potion-type check and an always-false brew guard, stale debug comment removal, and final locals. 2026-07-10 18:17:09 -0700e53f74c2751dbcb5d0ecd5bf958088e35e18649dAdd alchemy unit test coverage and tidy alchemy internalsaddsrc/test/java/com/gmail/nossr50/listeners/InventoryListenerBrewTest.javaaddsrc/test/java/com/gmail/nossr50/skills/alchemy/AlchemyPotionBrewerTest.javaeditsrc/main/java/com/gmail/nossr50/skills/alchemy/AlchemyManager.javaaddsrc/test/java/com/gmail/nossr50/datatypes/skills/alchemy/PotionStageTest.javaaddsrc/test/java/com/gmail/nossr50/skills/alchemy/AlchemyManagerTest.javaeditsrc/main/java/com/gmail/nossr50/datatypes/skills/alchemy/AlchemyPotion.javaeditsrc/main/java/com/gmail/nossr50/skills/alchemy/AlchemyPotionBrewer.javaaddsrc/test/java/com/gmail/nossr50/skills/alchemy/AlchemyTest.javaChangelog.txtsrc/test/java/com/gmail/nossr50/datatypes/skills/alchemy/AlchemyPotionTest.javasrc/main/java/com/gmail/nossr50/datatypes/skills/alchemy/AlchemyPotion.java406422a554449d4456e7a8dbd7062827b58267db1783732674000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comFix potion matching failing when custom effect order differs Custom effects were compared by list index, so two potions carrying identical effects in a different order were treated as different potions and the brew silently failed. Effects are now matched by type, amplifier, and duration regardless of order. 2026-07-10 18:17:54 -0700406422a554449d4456e7a8dbd7062827b58267dbFix potion matching failing when custom effect order differseditChangelog.txtaddsrc/test/java/com/gmail/nossr50/datatypes/skills/alchemy/AlchemyPotionTest.javaeditsrc/main/java/com/gmail/nossr50/datatypes/skills/alchemy/AlchemyPotion.javasrc/main/java/com/gmail/nossr50/skills/alchemy/AlchemyPotionBrewer.javaChangelog.txtsrc/test/java/com/gmail/nossr50/skills/alchemy/AlchemyPotionBrewerTransferTest.java71bad6a743390854fe28bf636b9329756810e76e1783732719000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comFix brewing stand ingredient transfers using the wrong stack limit Shift-right-click transfers checked the source stack against the max stack size instead of the ingredient slot, so a full source stack was wrongly refused while a full ingredient slot happily grew past the stack limit. Room is now judged by the destination stack, using the component-aware ItemStack#getMaxStackSize. 2026-07-10 18:18:39 -070071bad6a743390854fe28bf636b9329756810e76eFix brewing stand ingredient transfers using the wrong stack limiteditChangelog.txtaddsrc/test/java/com/gmail/nossr50/skills/alchemy/AlchemyPotionBrewerTransferTest.javaeditsrc/main/java/com/gmail/nossr50/skills/alchemy/AlchemyPotionBrewer.javasrc/test/java/com/gmail/nossr50/skills/archery/ArcheryManagerTest.javasrc/main/java/com/gmail/nossr50/skills/archery/Archery.javasrc/test/java/com/gmail/nossr50/skills/archery/ArcheryTest.javasrc/main/java/com/gmail/nossr50/skills/archery/ArcheryManager.javad3d52819267ca965f96d969a996306123da3fe4c1783733366000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd archery unit test coverage Covers the Skill Shot damage math and its max bonus cap, the arrow tracker and its periodic invalid-entity cleanup, ability gates, the distance XP multiplier (including the 50-block cap and cross-world guards), and both Daze branches: the Paper lookAt path and the Spigot scheduled-teleport path with its stale-world guard. Minor cleanup: final locals and a line wrap in the Archery helpers. 2026-07-10 18:29:26 -0700d3d52819267ca965f96d969a996306123da3fe4cAdd archery unit test coverageeditsrc/main/java/com/gmail/nossr50/skills/archery/ArcheryManager.javaeditsrc/main/java/com/gmail/nossr50/skills/archery/Archery.javaaddsrc/test/java/com/gmail/nossr50/skills/archery/ArcheryManagerTest.javaaddsrc/test/java/com/gmail/nossr50/skills/archery/ArcheryTest.javasrc/main/java/com/gmail/nossr50/skills/crossbows/CrossbowsManager.javasrc/test/java/com/gmail/nossr50/skills/crossbows/CrossbowsTest.javasrc/test/java/com/gmail/nossr50/skills/crossbows/CrossbowsManagerTest.java9f0afd6151e38136e52adba9b1a21315107f26651783733664000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd crossbows unit test coverage Covers the Trick Shot ricochet end to end: crossbow and permission gates, the bounce budget from the subskill rank, the head-on rejection window (first bounce only), the reflected arrow spawn with its copied combat state, tipped-arrow potion state, infinite-arrow pickup denial, and the hit routing that feeds it. Also covers the Powered Shot damage math and its activation gate. Minor cleanup: final locals and a corrected comment on the ricochet angle check. 2026-07-10 18:34:24 -07009f0afd6151e38136e52adba9b1a21315107f2665Add crossbows unit test coverageaddsrc/test/java/com/gmail/nossr50/skills/crossbows/CrossbowsManagerTest.javaeditsrc/main/java/com/gmail/nossr50/skills/crossbows/CrossbowsManager.javaaddsrc/test/java/com/gmail/nossr50/skills/crossbows/CrossbowsTest.javasrc/main/java/com/gmail/nossr50/skills/spears/SpearsManager.javasrc/test/java/com/gmail/nossr50/skills/spears/SpearsManagerTest.javaa3f6e55adaf5dae01d21ad19a931c7a7613149221783734232000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd spears unit test coverage Covers Momentum end to end: the lazy speed effect type resolution and its fail-fast when the registry lacks it, attack-strength-scaled activation odds with the full-strength clamp, the guard that never downgrades a stronger or longer existing swiftness buff, permission gating, and the buff application itself. Also covers the Momentum duration curve and the Spear Mastery bonus damage math. The tests bootstrap Bukkit Registry and PotionEffectType with mocks minted during their own static initialization, which makes registry-backed effect types mockable off-server. Minor cleanup: final locals and a clarified odds comment. 2026-07-10 18:43:52 -0700a3f6e55adaf5dae01d21ad19a931c7a761314922Add spears unit test coverageeditsrc/main/java/com/gmail/nossr50/skills/spears/SpearsManager.javaaddsrc/test/java/com/gmail/nossr50/skills/spears/SpearsManagerTest.javasrc/test/java/com/gmail/nossr50/skills/taming/TrackedTamingEntityTest.javasrc/test/java/com/gmail/nossr50/skills/taming/TamingManagerTest.javasrc/test/java/com/gmail/nossr50/skills/taming/TamingTest.javac9ac1407f2e5898ff47370a5a2e66aaf35c2287c1783735043000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd taming unit test coverage Covers the static Taming helpers (damage prevention gate, Thick Fur, Shock Proof, Holy Hound healing clamps, summon failure messages), taming XP with its cancellable event, Fast Food Service healing, Gore and Sharpened Claws damage math, Pummel knockback and its notifications, Environmentally Aware rescue teleports, Beast Lore messages including horse stats and the llama exclusion, the Call of the Wild summon flow (cost, cap, throttle, permission and item gates, wolf setup and tracking), and the tracked summon lifecycle. 2026-07-10 18:57:23 -0700c9ac1407f2e5898ff47370a5a2e66aaf35c2287cAdd taming unit test coverageaddsrc/test/java/com/gmail/nossr50/skills/taming/TrackedTamingEntityTest.javaeditsrc/test/java/com/gmail/nossr50/skills/taming/TamingManagerTest.javaaddsrc/test/java/com/gmail/nossr50/skills/taming/TamingTest.javasrc/test/java/com/gmail/nossr50/skills/taming/TamingManagerTest.javasrc/main/java/com/gmail/nossr50/skills/taming/TamingManager.javaChangelog.txtc72abd1a0c70dca848c592475c2be3098892ec6f1783735110000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comFix Holy Hound gating on the wrong subskill unlock Holy Hound checked Environmentally Aware's unlock level, so wolves were healed by magic and poison from Taming level 10 instead of the level 35 the skill guides advertise. It now gates on its own rank. 2026-07-10 18:58:30 -0700c72abd1a0c70dca848c592475c2be3098892ec6fFix Holy Hound gating on the wrong subskill unlockeditsrc/main/java/com/gmail/nossr50/skills/taming/TamingManager.javaeditChangelog.txteditsrc/test/java/com/gmail/nossr50/skills/taming/TamingManagerTest.javasrc/test/java/com/gmail/nossr50/skills/spears/SpearsManagerTest.javasrc/test/java/com/gmail/nossr50/TestRegistryBootstrap.javasrc/test/java/com/gmail/nossr50/skills/mining/BlastMiningTest.javasrc/main/java/com/gmail/nossr50/skills/mining/MiningManager.javasrc/test/java/com/gmail/nossr50/skills/mining/MiningManagerTest.javaa95ebfb2f1b52efaf9fee84387a8e2d892ed97041783735679000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd mining unit test coverage Covers miningBlockCheck end to end (XP, permission and config gates, silk touch handling, Super Breaker durability and triple drops, Mother Lode with its double-drop fallback), the remote detonation gate and flow (cooldown warning, instant TNT priming, denied fake breaks), blast mining drop processing (yield rolls, bonus drop tiers, debris rolls, illegal drops), the blast modifiers and drop multiplier tiers, the Demolitions Expertise and Bigger Bombs unlock scans, and the PVP blast damage cap and owner damage reduction. Extracts the registry bootstrap proven in the spears tests into a shared TestRegistryBootstrap that mints per-type registry mocks, so Enchantment and PotionEffectType are both safely mockable off-server regardless of suite order. Minor cleanup: corrected five copy-pasted javadocs on the blast modifier getters. 2026-07-10 19:07:59 -0700a95ebfb2f1b52efaf9fee84387a8e2d892ed9704Add mining unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/mining/MiningManagerTest.javaaddsrc/test/java/com/gmail/nossr50/TestRegistryBootstrap.javaeditsrc/test/java/com/gmail/nossr50/skills/mining/BlastMiningTest.javaeditsrc/main/java/com/gmail/nossr50/skills/mining/MiningManager.javaeditsrc/test/java/com/gmail/nossr50/skills/spears/SpearsManagerTest.javasrc/test/java/com/gmail/nossr50/skills/swords/SwordsManagerTest.javaff435173ce4390d5b0da368f2f1a8da86498efed1783735885000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd swords unit test coverage Covers the ability gates (readied sword, living-attacker counter gate, active super ability), the Rupture flow (refresh instead of re-roll, blocking defenders, bleed task scheduling and defender notification), Stab damage scaling, Counter Attack reflection with its notifications, and Serrated Strikes AoE damage reduction. 2026-07-10 19:11:25 -0700ff435173ce4390d5b0da368f2f1a8da86498efedAdd swords unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/swords/SwordsManagerTest.javasrc/test/java/com/gmail/nossr50/skills/axes/AxesManagerTest.java41d1dadccc4e3898bc12f860155ac426e6d33a2a1783736097000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd axes unit test coverage Covers the ability gates including the armored/naked target split between Armor Impact and Greater Impact, Axe Mastery scaling, the Critical Hit PVP path with its notifications, Impact armor durability damage and its no-equipment guard, the Greater Impact knockback and bonus damage payout, and the armor detection helper. Also adds save/restore hygiene for the Axes static modifiers the existing tests mutated. 2026-07-10 19:14:57 -070041d1dadccc4e3898bc12f860155ac426e6d33a2aAdd axes unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/axes/AxesManagerTest.javasrc/test/java/com/gmail/nossr50/skills/unarmed/UnarmedManagerTest.java1b44bb55a8f302c746d24d97eb65ceb997cce2f81783736330000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd unarmed unit test coverage Covers the ability gates (armed-player disarm targets, empty-fist arrow deflect, active Berserk, readied fists), all six Block Cracker brick conversions with the config and activation gates, the full Disarm flow (protected drops, Iron Grip saves, cancelled events), Arrow Deflect, and the Steel Arm damage curve including the rank 18 breakpoint and the custom override. 2026-07-10 19:18:50 -07001b44bb55a8f302c746d24d97eb65ceb997cce2f8Add unarmed unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/unarmed/UnarmedManagerTest.javasrc/test/java/com/gmail/nossr50/skills/excavation/ExcavationTest.javad5390b64300d5e7128421104dc4ea5d837182fc81783736514000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd excavation unit test coverage Covers block XP, the Giga Drill Breaker double XP check with tool durability and its tripled treasure rolls, treasure drop-level gating, treasure XP payouts, archaeology experience orb rolls and their rank scaling, and the archaeology permission gate. 2026-07-10 19:21:54 -0700d5390b64300d5e7128421104dc4ea5d837182fc8Add excavation unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/excavation/ExcavationTest.javasrc/test/java/com/gmail/nossr50/skills/maces/MacesTest.javaadc1a10327e52ea696dfbbc6b3c30bba0c8a04d41783736683000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd maces unit test coverage Covers the Cripple flow end to end: the lazy slowness effect type resolution and its fail-fast, the do-not-stack guard against already slowed targets, attack-strength-scaled odds, permission gating, the player/mob tier split for slow duration and strength, and the effect application with its notification. Crush damage was already covered. 2026-07-10 19:24:43 -0700adc1a10327e52ea696dfbbc6b3c30bba0c8a04d4Add maces unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/maces/MacesTest.javasrc/test/java/com/gmail/nossr50/skills/smelting/SmeltingManagerTest.java2c917cb4a7e5b63da8850d95684918a31be05f0f1783736851000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd smelting unit test coverage Covers the Fuel Efficiency multiplier tiers with the spent-fuel and Short.MAX_VALUE clamps, smelt XP payouts, and the Second Smelt flow: the winning roll adding an ingot, the nearly-full result slot guard, and the per-item double drop config gate. The vanilla XP multiplier was already covered. 2026-07-10 19:27:31 -07002c917cb4a7e5b63da8850d95684918a31be05f0fAdd smelting unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/smelting/SmeltingManagerTest.javasrc/test/java/com/gmail/nossr50/skills/repair/RepairManagerTest.java646f831b364c6aa71ea79f6aeddbd6f5bb6516fe1783737207000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd repair unit test coverage Covers the anvil placement hint firing exactly once, every handleRepair guard rail (unbreakable, custom model data, permission, skill level, full durability, missing material, stacked items), the Repair Mastery bonus and Super Repair double with its notification, and the Arcane Forging outcomes: rank-zero loss, kept enchants, stripped enchants, and downgrades. Confirmation windows and the arcane forging enchant cap were already covered. 2026-07-10 19:33:27 -0700646f831b364c6aa71ea79f6aeddbd6f5bb6516feAdd repair unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/repair/RepairManagerTest.javasrc/test/java/com/gmail/nossr50/skills/salvage/SalvageManagerTest.javac5554a5b313f65b3334f9b230c77bfd4f9cbf0a11783737453000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd salvage unit test coverage Covers the Scrap Collector yield limits, the enchant bypass perk guaranteeing full extraction, the anvil placement hint firing once, the handleSalvage guard rails (unbreakable, skill level, too damaged), the successful salvage flow with its material payout and hand emptying, and the arcane salvage split between lost enchants and full book extraction. Confirmation windows and the enchant cap were already covered. 2026-07-10 19:37:33 -0700c5554a5b313f65b3334f9b230c77bfd4f9cbf0a1Add salvage unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/salvage/SalvageManagerTest.javasrc/test/java/com/gmail/nossr50/skills/herbalism/HerbalismManagerAbilitiesTest.javacc392fa051990f62afce5cc64511b44b0ae811491783737974000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd herbalism ability unit test coverage Covers the ability gates (Green Thumb seed requirements, Shroom Thumb needing both mushroom types, Hylian Luck, readied hoe), Farmer's Diet delegation, the sweet berry bush harvest with its delayed age verification and cancelled-harvest guard, plant maturity rules including the berry bush age-two rule and the untrustworthy ageables, bonus drop marking (Green Terra and Verdant Bounty triples versus plain doubles), and the natural/player-placed double drop split. Green Thumb consumption and multi-block XP were already covered. 2026-07-10 19:46:14 -0700cc392fa051990f62afce5cc64511b44b0ae81149Add herbalism ability unit test coverageaddsrc/test/java/com/gmail/nossr50/skills/herbalism/HerbalismManagerAbilitiesTest.javasrc/test/java/com/gmail/nossr50/skills/woodcutting/WoodcuttingTest.java580bc40b7a392478dab1921cb1959485a9b4eb4b1783738202000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd woodcutting gate and Clean Cuts unit test coverage Covers the Leaf Blower and Tree Feller gates (axe requirement, unlock, active ability) and the Clean Cuts triple drop paths: the metadata marking on single-block breaks and the direct double spawn under Tree Feller. Double drops, XP, the Tree Feller threshold, Knock on Wood orbs, and durability were already covered. 2026-07-10 19:50:02 -0700580bc40b7a392478dab1921cb1959485a9b4eb4bAdd woodcutting gate and Clean Cuts unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/woodcutting/WoodcuttingTest.javasrc/test/java/com/gmail/nossr50/skills/acrobatics/AcrobaticsTest.javad0214f1dc3beb69a9c6509e4bfd6e3e981c940e01783738410000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd acrobatics gate and throttle unit test coverage Covers the Dodge gate (blocking players, PVE trigger config, the lightning config, the unlock), the roll XP throttle with its lengthening cooldown under exploit prevention, and the fall location memory. Roll damage, thresholds, graceful roll probability, and the per-mob dodge XP cap were already covered. 2026-07-10 19:53:30 -0700d0214f1dc3beb69a9c6509e4bfd6e3e981c940e0Add acrobatics gate and throttle unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/acrobatics/AcrobaticsTest.javasrc/test/java/com/gmail/nossr50/util/random/ProbabilityTestUtils.javac25b48e7812f718cdaba7da7801c9a442efb3e291783739022000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comWiden statistical tolerance in probability expectation tests At 20 million samples the old 0.035 percentage point tolerance sat around 3 sigma, so the parameterized static-chance cases would flake on an unlucky roll every few hundred runs. 0.05 keeps roughly 4.5 sigma of headroom while still catching any real probability regression. 2026-07-10 20:03:42 -0700c25b48e7812f718cdaba7da7801c9a442efb3e29Widen statistical tolerance in probability expectation testseditsrc/test/java/com/gmail/nossr50/util/random/ProbabilityTestUtils.javasrc/test/java/com/gmail/nossr50/skills/fishing/FishingManagerProcessFishingTest.javasrc/test/java/com/gmail/nossr50/skills/fishing/FishingManagerMasterAnglerTest.javasrc/test/java/com/gmail/nossr50/listeners/PlayerListenerFishingTest.java0bf608a425587c65384f6532f3df94c1c84b84d61783739847000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comAdd fishing enchantment unit test coverage Covers the enchantment-backed fishing paths: the cast wiring that reads the rod Lure level and hands it to Master Angler, the deferred Master Angler task scheduled one tick after the cast, Luck of the Sea scaling of the treasure roll (main hand, off hand, unenchanted, and unknown hand), and the Magic Hunter roll including candidate filtering, the conflict rule, non-enchantable drops, and the locked gate. These were previously untestable off-server because Enchantment resolves through the registry; the registry bootstrap added for the spears coverage unblocks them. 2026-07-10 20:17:27 -07000bf608a425587c65384f6532f3df94c1c84b84d6Add fishing enchantment unit test coverageeditsrc/test/java/com/gmail/nossr50/skills/fishing/FishingManagerMasterAnglerTest.javaeditsrc/test/java/com/gmail/nossr50/listeners/PlayerListenerFishingTest.javaeditsrc/test/java/com/gmail/nossr50/skills/fishing/FishingManagerProcessFishingTest.javagithttps://popicraft.net/jenkins/user/nossr50nossr50