Started by an SCM change359f77233db9983cf4af29b495a68dfad6333344210f77233db9983cf4af29b495a68dfad6333344210refs/remotes/origin/masterf77233db9983cf4af29b495a68dfad6333344210f77233db9983cf4af29b495a68dfad6333344210refs/remotes/origin/masterf77233db9983cf4af29b495a68dfad6333344210f77233db9983cf4af29b495a68dfad6333344210refs/remotes/origin/masterhttps://github.com/mcMMO-Dev/mcMMO.gitmcMMO.jarmcMMO.jartarget/mcMMO.jaroriginal-mcMMO.jaroriginal-mcMMO.jartarget/original-mcMMO.jarfalse#3597605466807mcMMO #359359falsefalse359305SUCCESS1790038152724https://popicraft.net/jenkins/job/mcMMO/359/Buildersrc/main/java/com/gmail/nossr50/skills/crossbows/CrossbowsManager.javasrc/test/java/com/gmail/nossr50/skills/crossbows/CrossbowsManagerTest.java9168683b6d9aeea3b16365592e6c7365f0f19a5f1789621745000https://popicraft.net/jenkins/user/127477265+cyrne1-7208127477265+cyrne1-7208127477265+cyrne1-7208@users.noreply.github.comAvoid in-place Vector mutation in Crossbow ricochet calculations In CrossbowsManager.handleRicochet(), Bukkit Vector arithmetic methods (subtract, multiply) mutate the receiver in place. The reflection formula previously mutated both arrowInBlockVector and normal, and then reused the mutated normal to compute inverseNormal. While the existing production path produces new Vector instances for projectile hits, mutating arguments passed into a public method is unsafe for future callers and external consumers. This change: - Clones vectors before in-place mutations (subtract, multiply) so that supplied arguments and intermediate vectors remain unmodified. - Eliminates inverseNormal by directly comparing reflectedDirection.angle(normal), matching the comment description and specular reflection geometry. - Avoids Vector.normalize() on the surface normal, avoiding potential NaN values if a non-cardinal zero vector is supplied. - Adds a unit test ensuring that neither the arrow velocity nor the surface normal vector is mutated during handleRicochet(). Signed-off-by: Cyrne1_7208 <127477265+cyrne1-7208@users.noreply.github.com> 2026-09-17 05:09:05 +00009168683b6d9aeea3b16365592e6c7365f0f19a5fAvoid in-place Vector mutation in Crossbow ricochet calculationseditsrc/main/java/com/gmail/nossr50/skills/crossbows/CrossbowsManager.javaeditsrc/test/java/com/gmail/nossr50/skills/crossbows/CrossbowsManagerTest.javapom.xml6166d098296fbd8ae0ed8711f64dca21129b2b921790022472000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.com2.3.002 snapshots 2026-09-21 13:27:52 -07006166d098296fbd8ae0ed8711f64dca21129b2b922.3.002 snapshotseditpom.xmlsrc/test/java/com/gmail/nossr50/util/RecipeUtilsTest.javasrc/test/java/com/gmail/nossr50/util/skills/SkillUtilsTest.javasrc/main/java/com/gmail/nossr50/util/ItemUtils.javasrc/main/java/com/gmail/nossr50/util/RecipeUtils.javasrc/test/java/com/gmail/nossr50/util/ThrowingRecipeIterator.javasrc/main/java/com/gmail/nossr50/util/skills/SkillUtils.javasrc/test/java/com/gmail/nossr50/util/ItemUtilsTest.javaChangelog.txt6b055d2a370131d04abe3836d41f3f100189f4711790037588000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comFix mcMMO failing to enable on Spigot 26.3 Minecraft 26.3 made brewing recipes data-driven, so they now sit in the server's recipe manager. Spigot 26.3 has no Bukkit counterpart for them: BrewingRecipe does not implement toBukkitRecipe, so Server.recipeIterator() throws AbstractMethodError from next() for every brewing recipe. SalvageConfig counts ingredients through SkillUtils.getRepairAndSalvageQuantities while loading, which walks that iterator, so onEnable died and mcMMO disabled itself. Spigot's Server.getRecipesFor walks the same iterator, so ItemUtils.isSmelted would have thrown at runtime on furnace extraction as well. RecipeUtils.safeRecipeIterator wraps the server iterator and skips recipes the server cannot convert. CraftBukkit advances its underlying iterator before converting, so a failed entry is already consumed and the walk continues with the next one. Both call sites use it, and hasOreSmeltingRecipe filters by result type itself instead of calling getRecipesFor. Servers that convert every recipe (Paper 26.3, and Paper and Spigot 1.20.6) see the same recipes in the same order as before. Fixes #5346 2026-09-21 17:39:48 -07006b055d2a370131d04abe3836d41f3f100189f471Fix mcMMO failing to enable on Spigot 26.3editsrc/main/java/com/gmail/nossr50/util/skills/SkillUtils.javaaddsrc/test/java/com/gmail/nossr50/util/ThrowingRecipeIterator.javaeditsrc/test/java/com/gmail/nossr50/util/ItemUtilsTest.javaeditsrc/test/java/com/gmail/nossr50/util/skills/SkillUtilsTest.javaaddsrc/main/java/com/gmail/nossr50/util/RecipeUtils.javaaddsrc/test/java/com/gmail/nossr50/util/RecipeUtilsTest.javaeditChangelog.txteditsrc/main/java/com/gmail/nossr50/util/ItemUtils.javasrc/main/java/com/gmail/nossr50/skills/repair/repairables/SimpleRepairable.javaChangelog.txtsrc/test/java/com/gmail/nossr50/skills/repair/repairables/SimpleRepairableTest.java5f2e9f86009a561f8f5b1b479be9328d139f1b8c1790037588000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comCount repair ingredients once per repairable instead of on every repair SimpleRepairable.getMinimumQuantity fell through to SkillUtils.getRepairAndSalvageQuantities whenever MinimumQuantity was not configured, and RepairManager reaches it through getBaseRepairDurability on every anvil repair. That method converts every recipe on the server to its Bukkit form, around two thousand of them, and on Spigot 26.3 each walk also throws and catches an AbstractMethodError per brewing recipe. The recipe count is now kept in a field after the first repair of that item type. The field is a plain int: a count is always at least one, zero means not counted yet, and an int write is atomic, so a racing region thread either counts for itself or reads a usable value. Recipes changed after the first repair are no longer picked up, which matches Salvage, where the count has always been taken once at startup. A configured quantity of zero or less now falls back to the recipe count as well. It is the divisor of the base repair amount, and only a configured zero was mapped to the fallback before, so a negative value in repair.vanilla.yml or a zero passed to RepairableFactory by another plugin produced a negative repair or a division by zero. 2026-09-21 17:39:48 -07005f2e9f86009a561f8f5b1b479be9328d139f1b8cCount repair ingredients once per repairable instead of on every repaireditsrc/main/java/com/gmail/nossr50/skills/repair/repairables/SimpleRepairable.javaeditChangelog.txtaddsrc/test/java/com/gmail/nossr50/skills/repair/repairables/SimpleRepairableTest.javasrc/test/java/com/gmail/nossr50/util/RecipeUtilsTest.javasrc/main/java/com/gmail/nossr50/util/ItemUtils.javasrc/main/java/com/gmail/nossr50/util/skills/SkillUtils.javasrc/main/java/com/gmail/nossr50/util/RecipeUtils.java13ea4c34c9da40ace04a64456f51e27961eb8a821790037589000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comOnly tolerate AbstractMethodError in the recipe walk and log what was skipped safeRecipeIterator also swallowed UnsupportedOperationException, which no server is known to throw from its recipe iterator. Swallowing it hid unrelated failures, and because a skipped entry is assumed to be consumed, an iterator that keeps throwing without advancing turned the walk into an endless loop. Only the AbstractMethodError that Spigot 26.3 produces is skipped now; anything else reaches the caller. A walk that completes after skipping recipes writes one debug line with the count and the first failure, shown when General.Verbose_Logging is on. A server that failed to convert a crafting recipe would otherwise lower Repair and Salvage quantities with nothing in the log to explain it. Walks that stop early, like the ore smelting lookup, stay quiet since their count would be partial. The iterator takes the logger as a parameter for this. 2026-09-21 17:39:49 -070013ea4c34c9da40ace04a64456f51e27961eb8a82Only tolerate AbstractMethodError in the recipe walk and log what was skippededitsrc/main/java/com/gmail/nossr50/util/skills/SkillUtils.javaeditsrc/main/java/com/gmail/nossr50/util/ItemUtils.javaeditsrc/test/java/com/gmail/nossr50/util/RecipeUtilsTest.javaeditsrc/main/java/com/gmail/nossr50/util/RecipeUtils.javaChangelog.txt4626785d5f175acdf90aa763d2ffe18bfd61c89d1790037589000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comNote that the Spigot 26.3 startup failure is a Spigot bug mcMMO works around 2026-09-21 17:39:49 -07004626785d5f175acdf90aa763d2ffe18bfd61c89dNote that the Spigot 26.3 startup failure is a Spigot bug mcMMO works aroundeditChangelog.txtgithttps://popicraft.net/jenkins/user/nossr50nossr50https://popicraft.net/jenkins/user/127477265+cyrne1-7208127477265+cyrne1-7208