Started by an SCM change3624a33756ca0689495d3c9e2f31fa310326fa017104a33756ca0689495d3c9e2f31fa310326fa01710refs/remotes/origin/master4a33756ca0689495d3c9e2f31fa310326fa017104a33756ca0689495d3c9e2f31fa310326fa01710refs/remotes/origin/master4a33756ca0689495d3c9e2f31fa310326fa017104a33756ca0689495d3c9e2f31fa310326fa01710refs/remotes/origin/masterhttps://github.com/mcMMO-Dev/mcMMO.gitmcMMO.jarmcMMO.jartarget/mcMMO.jaroriginal-mcMMO.jaroriginal-mcMMO.jartarget/original-mcMMO.jarfalse#3626359366807mcMMO #362362falsefalse362309SUCCESS1790125454100https://popicraft.net/jenkins/job/mcMMO/362/Buildersrc/main/java/com/gmail/nossr50/database/FlatFileDatabaseManager.javasrc/test/java/com/gmail/nossr50/database/FlatFileDatabaseManagerTest.java4fb5035aebd30d34d2cb5ba9835ef520a90662be1790124370000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comReport FlatFile writes that fail instead of claiming success writeStringToFileSafely logged and swallowed any IOException from the write, so every operation that rewrote mcmmo.users returned success whether or not anything reached disk. saveUser told PlayerProfile the profile was saved, so it was never retried. saveUserUUIDs told the UUID upgrade its batch was stored, and removeUser, saveUserUUID and purgePowerlessUsers reported changes that never happened. The helper now returns whether the write went through, rewriteUsersFile returns it, and each caller passes it on and skips its success logging when it failed. The users file writer is opened through a package-private factory, alongside the existing reader factory, so tests can make it fail. The mid-read failure tests are split into one parameterized case per operation so each broken path fails on its own, and write failures get the same coverage. 2026-09-22 17:46:10 -07004fb5035aebd30d34d2cb5ba9835ef520a90662beReport FlatFile writes that fail instead of claiming successeditsrc/main/java/com/gmail/nossr50/database/FlatFileDatabaseManager.javaeditsrc/test/java/com/gmail/nossr50/database/FlatFileDatabaseManagerTest.javaChangelog.txta9bed7cd00ce445695291e0834f844fd36c7f4e61790124371000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comCredit cyrne1-7208 for the FlatFile read failure fix 2026-09-22 17:46:11 -0700a9bed7cd00ce445695291e0834f844fd36c7f4e6Credit cyrne1-7208 for the FlatFile read failure fixeditChangelog.txtsrc/test/java/com/gmail/nossr50/commands/skills/SmeltingCommandTest.java4a33756ca0689495d3c9e2f31fa310326fa017101790125201000https://popicraft.net/jenkins/user/nossr50nossr50nossr50@gmail.comCover the /smelting Vanilla XP multiplier line against a real advanced.yml The existing Smelting tests stub the config getter, so nothing checked that a value typed into advanced.yml reaches the stat line players see. The new test writes an edited copy of the shipped advanced.yml, loads it through AdvancedConfig, and runs the real SmeltingCommand stat steps. It pins that configured whole numbers are shown at every rank, that decimals are rounded down and never shown below 1x, and that the line is hidden until Understanding The Art unlocks. Showing the rank instead of the configured value fails it. 2026-09-22 18:00:01 -07004a33756ca0689495d3c9e2f31fa310326fa01710Cover the /smelting Vanilla XP multiplier line against a real advanced.ymladdsrc/test/java/com/gmail/nossr50/commands/skills/SmeltingCommandTest.javagithttps://popicraft.net/jenkins/user/nossr50nossr50