Skip to content

Changes

Started 6 days 11 hr ago
Took 52 sec on Builder

Summary

  1. Fix KnockOnWood XP orbs never spawning on nether tree cap blocks during Tree Feller (commit: 8ff047d) (details)
  2. Rename underscore test method names to camelCase in WoodcuttingTest; clean up 2.2.053 changelog entries (commit: c838a69) (details)
  3. Fix Impale damage formula: use rank * multiplier instead of (rank - 1) * multiplier (commit: 71868d9) (details)
Commit 8ff047d5a1a77f0f58c391ac41e9920f0e2b7199 by nossr50
Fix KnockOnWood XP orbs never spawning on nether tree cap blocks during Tree Feller

Nether_Wart_Block and Warped_Wart_Block both have woodcutting XP in
experience.yml AND are in the treeFellerDestructibleWhiteList. The
drop routing in dropTreeFellerLootFromBlocks used an if/else-if
structure, so blocks with woodcutting XP always took the first branch
and never reached the else-if where the KnockOnWood orb logic lived.

Fix: extract the orb spawning block into a standalone if-check that
runs after the drop routing, so it fires for any isNonWoodPartOfTree
block regardless of whether it also has woodcutting XP.

Fixes #5288
(commit: 8ff047d)
The file was modifiedsrc/main/java/com/gmail/nossr50/skills/woodcutting/WoodcuttingManager.java (diff)
The file was modifiedsrc/test/java/com/gmail/nossr50/skills/woodcutting/WoodcuttingTest.java (diff)
The file was modifiedChangelog.txt (diff)
Commit c838a69e7eafd6a20dd218f02fbef956abce66df by nossr50
Rename underscore test method names to camelCase in WoodcuttingTest; clean up 2.2.053 changelog entries
(commit: c838a69)
The file was modifiedChangelog.txt (diff)
The file was modifiedsrc/test/java/com/gmail/nossr50/skills/woodcutting/WoodcuttingTest.java (diff)
Commit 71868d9d2e87230ea0f8b8628edbf8ff869e0155 by nossr50
Fix Impale damage formula: use rank * multiplier instead of (rank - 1) * multiplier
(commit: 71868d9)
The file was modifiedsrc/main/java/com/gmail/nossr50/skills/tridents/TridentsManager.java (diff)
The file was modifiedsrc/test/java/com/gmail/nossr50/skills/tridents/TridentsTest.java (diff)