Fix combat effects reading stale attack cooldown on Paper 26.1.2+
Paper 26.1.2 resets the attack strength ticker before EntityDamageByEntityEvent fires, so Player.getAttackCooldown() reads ~0.1 during damage processing. 2.2.053 fixed the damage bonus scaling in CombatUtils, but everything that still read the cooldown through McMMOPlayer#getAttackStrength() stayed broken:
- Berserk's +50% bonus went negative, reducing a 9.0 damage punch to ~1.35 instead of boosting it to 13.5 - Skull Splitter AoE damage was cut to ~10% - On-hit odds for Disarm, Rupture (also via Serrated Strikes), Cripple, Momentum, Critical Strikes, Armor Impact, and Greater Impact were cut to ~10%
These now take the attack strength scale that CombatUtils back-derives from the damage event. The old signatures and McMMOPlayer#getAttackStrength are deprecated. (commit: 88f0627)
Make action bar unlock messages a deliberate opt-in
Routing skill rank unlock messages to the action bar is now controlled by a new Feedback.ActionBarNotifications.SubSkillUnlocked.UseActionBar key in advanced.yml, defaulting to false.
The previous approach honored the existing SubSkillUnlocked.Enabled key, but configs from older versions already contain 'Enabled: true' from back when the setting had no effect, so updating would have silently moved unlock messages to the action bar on those servers. The Enabled key is now ignored for this section; unlock messages stay in chat unless an admin explicitly sets UseActionBar to true. (commit: fbab8db)
Rename SubSkillUnlocked opt-in key to SendToActionBar
SendToActionBar matches the naming of the sibling SendCopyOfMessageToChat key; UseActionBar matched nothing else in advanced.yml. The key is unreleased so no migration is needed. (commit: bc1bcb8)
